Repository navigation
gh-159127: Fix tests depending on the layout of unmapped text widgets - #159128
Merged
serhiy-storchaka merged 1 commit intoOct 10, 2026
Merged
Conversation
…idgets A text widget which has not been mapped yet had size 1x1 and its content was laid out in that area, putting every character on its own display line. Tk no longer does this.
serhiy-storchaka
added
skip news
tests
serhiy-storchaka
added
needs backport to 3.14
serhiy-storchaka
enabled auto-merge (squash)
October 10, 2026 16:28
terryjreedy
approved these changes
Oct 10, 2026
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-159133 is a backport of this pull request to the 3.15 branch. |
|
GH-159134 is a backport of this pull request to the 3.14 branch. |
orsenthil
pushed a commit
to orsenthil/cpython
that referenced
this pull request
Oct 11, 2026
…idgets (pythonGH-159128) A text widget which has not been mapped yet had size 1x1 and its content was laid out in that area, putting every character on its own display line. Tk no longer does this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_countnow maps the text widget and expects zero vertical pixels between indices on the same display line.The
codecontexttests now use a text longer than the visible height of the widget, so that it can be scrolled.test_scrollnow maps the windows, because synchronized scrolling depends on the geometry of mapped widgets. It failed with all Tk versions when run alone.Tested with Tk 8.6.17, 8.6.18, 9.0.3, the 9.0 branch tip (9.0.5) and the trunk (9.1.1), and with 9.1b1.